search

Icinga / docker-icingaweb2

GNU General Public License v2.0
16 stars 11 forks source link

Bump base image version #116

Closed Al2Klimov closed 2 weeks ago

Al2Klimov commented 1 year ago

Omitting virtual php8.2-json, that extension is always there since PHP 8.

DbCommand now supports PHP 8.2 by not creating dynamic properties.

fixes #128

Al2Klimov commented 1 year ago

Tested with https://github.com/Al2Klimov/twintowers .

It's for you to decide whether this makes sense for 2.12.1 or not.

Al2Klimov commented 1 year ago

⚠️

If we merge this, you'll have to pin this GHA to a previous commit in upstream support branches not supporting PHP 8.2! (I can do this for you.)

Al2Klimov commented 1 year ago

Alternative

Wait for all IW2 versions not supporting PHP 8.2 to EOL.

julianbrost commented 1 year ago

Yet another alternative: make a @v2 version when doing incompatible changes.

Al2Klimov commented 9 months ago

But then we'd have to maintain multiple branches. My alternative involves less maintenance and it's realistic because Debian 11 will be maintained until Jul 2026. I don't know the exact IW2 release schedule, but idk why we shouldn't see at least a v2.13 by then. Also, why to force all image users to support PHP 8.2 right now? I'd say let's wait 1y+ before bumping the base images. CC @nicolasberens

Al2Klimov commented 2 months ago

Fact-check

This is false

https://github.com/Icinga/docker-icingaweb2/pull/116#issuecomment-1780968051

⚠️

If we merge this, you'll have to pin this GHA to a previous commit in upstream support branches not supporting PHP 8.2! (I can do this for you.)

https://github.com/Icinga/docker-icingaweb2/pull/116#issuecomment-1780977746

Alternative

Wait for all IW2 versions not supporting PHP 8.2 to EOL.

https://github.com/Icinga/docker-icingaweb2/pull/116#issuecomment-1945857977

But then we'd have to maintain multiple branches. My alternative involves less maintenance and it's realistic because Debian 11 will be maintained until Jul 2026. I don't know the exact IW2 release schedule, but idk why we shouldn't see at least a v2.13 by then. Also, why to force all image users to support PHP 8.2 right now? I'd say let's wait 1y+ before bumping the base images. CC @nicolasberens

This is true

Al2Klimov commented 2 months ago

@lippserd I've re-built and pushed :2.12.1, :2.12, etc. with this branch, so that we have PHP 8.2 for K8s. So this PR should be merged before a v2.12.2, not to loose PHP 8.2. 😅

Al2Klimov commented 1 month ago

@lippserd Not only it already confuses people (1) that :latest already has PHP 8 while :main doesn't, the latter surely breaks K8s-web in :main, our "snapshot images". 🙈 Two more reasons to merge this. 😅

  1. 128

Al2Klimov commented 2 weeks ago

@lippserd I'd like you to merge this, given that there's a complete v2.12.2 milestone already. It's pointless IMAO not to merge this if I'll build and push the image by hand anyway.

We've automated this in the first place to avoid mistakes one can make manually.