Icinga / icinga2

The core of our monitoring platform with a powerful configuration language and REST API.
https://icinga.com/docs/icinga2/latest
GNU General Public License v2.0
2.03k stars 579 forks source link

[dev.icinga.com #6917] enforce /usr/lib as base for the cgi path on SUSE distributions #1885

Closed icinga-migration closed 10 years ago

icinga-migration commented 10 years ago

This issue has been migrated from Redmine: https://dev.icinga.com/issues/6917

Created by theh on 2014-08-14 14:02:07 +00:00

Assignee: theh Status: Resolved (closed on 2014-08-22 13:45:04 +00:00) Target Version: 2.1.0 Last Update: 2014-08-25 09:13:27 +00:00 (in Redmine)

Icinga Version: 2.0.2

The cgi path on SUSE distributions is always located under /usr/lib/icinga/cgi, even on x86_64 systems. So the path in the icinga-classic-apache.conf needs to be adapted on these distributions.

Changesets

2014-08-17 10:32:22 +00:00 by theh 96e23aa1c7c2ba51ec330a7ede4491aae5cf8706

Enforce /usr/lib as base for the cgi path on SUSE distributions

The cgi path on SUSE distributions is always located under
/usr/lib/icinga/cgi, even on x86_64 systems.
So the path in the icinga-classic-apache.conf needs to be adapted on
those distributions.

fixes #6917

2014-08-22 13:41:44 +00:00 by (unknown) 4b3afd52d492983e7789294b3bfaf3cc6e25ad80

Revert "Enforce /usr/lib as base for the cgi path on SUSE distributions"

This reverts commit 96e23aa1c7c2ba51ec330a7ede4491aae5cf8706.

fixes #6917

Relations:

icinga-migration commented 10 years ago

Updated by theh on 2014-08-14 14:54:50 +00:00

icinga-migration commented 10 years ago

Updated by theh on 2014-08-17 10:33:51 +00:00

Applied in changeset 96e23aa1c7c2ba51ec330a7ede4491aae5cf8706.

icinga-migration commented 10 years ago

Updated by gbeutner on 2014-08-17 10:34:06 +00:00

icinga-migration commented 10 years ago

Updated by mfriedrich on 2014-08-17 14:27:09 +00:00

That's not true, the icinga-core spec file uses lib64 similar to rhel.

https://git.icinga.org/?p=icinga-core.git;a=blob;f=icinga.spec;hb=HEAD

That fix breaks the packages built on packages.icinga.org

icinga-migration commented 10 years ago

Updated by theh on 2014-08-18 07:36:26 +00:00

dnsmichi wrote:

That's not true, the icinga-core spec file uses lib64 similar to rhel.

https://git.icinga.org/?p=icinga-core.git;a=blob;f=icinga.spec;hb=HEAD

That fix breaks the packages built on packages.icinga.org Ok, let me check if I can change this path in our package without changing the others like the plugins dir.

icinga-migration commented 10 years ago

Updated by theh on 2014-08-19 10:03:49 +00:00

Ok, so I see three possibilities.

  1. Just maintain the one sed statement in the spec independent of upstream.
  2. I change the the cgi path in our Icinga packages and add a postinstall script to update it for all existing users.
  3. You change the path in your icinga spec for SUSE users and add the postinstall script.

I am not a big fan of 2 and you most likely don't want to do 3 so I would stick with 1 for now unless you have a better idea.

Then of course my commit needs to be reverted.

Btw. from a packaging standpoint the cgi files (and plugins) shouldn't be stored in an architecture dependent directory since these are no real libraries. These can be considered libexec files http://www.linuxbase.org/betaspecs/fhs/fhs/ch04s07.html and _libexec points in our case to /usr/lib and on Redhat to /usr/libexec.

icinga-migration commented 10 years ago

Updated by mfriedrich on 2014-08-22 13:27:30 +00:00

We'll go with 1):

icinga-migration commented 10 years ago

Updated by mfriedrich on 2014-08-22 13:40:24 +00:00

icinga-migration commented 10 years ago

Updated by mfriedrich on 2014-08-22 13:43:38 +00:00

icinga-migration commented 10 years ago

Updated by Anonymous on 2014-08-22 13:45:04 +00:00

Applied in changeset 4b3afd52d492983e7789294b3bfaf3cc6e25ad80.

icinga-migration commented 10 years ago

Updated by theh on 2014-08-25 09:13:27 +00:00

Thx, great idea.