Icinga / icinga2

The core of our monitoring platform with a powerful configuration language and REST API.
https://icinga.com/docs/icinga2/latest
GNU General Public License v2.0
2.03k stars 579 forks source link

[dev.icinga.com #10503] Missing parameters for check jmx4perl #3576

Closed icinga-migration closed 9 years ago

icinga-migration commented 9 years ago

This issue has been migrated from Redmine: https://dev.icinga.com/issues/10503

Created by hostedpower on 2015-10-31 12:06:20 +00:00

Assignee: mfriedrich Status: Resolved (closed on 2015-11-05 16:55:03 +00:00) Target Version: 2.4.0 Last Update: 2015-11-12 15:34:46 +00:00 (in Redmine)

Backport?: No
Include in Changelog: 1

Hi,

I'm trying to use object CheckCommand "jmx4perl" inside /usr/share/icinga2/include/plugins-contrib.d/web.conf

But I'm missing 3 important parameters which allow to work with a configuration file, I added them myself for now:

                                "--config" = {
                                                value = "$jmx4perl_config$"
                                                description = "Path to configuration file."
                                }
                                "--check" = {
                                                value = "$jmx4perl_check$"
                                                description = "Name of a check configuration as defined in the configuration file"
                                }
                                "--server" = {
                                                value = "$jmx4perl_server$"
                                                description = "Symbolic name of server url to use, which needs to be configured in the configuration file"
                                }

Could you please add them in the official version? Now I need to add them on each server over and over again :(

Please let me know if you would need any further details.

Kind regards Jo Goossens

Attachments

Changesets

2015-11-05 16:50:47 +00:00 by hostedpower 773e398799900765b13f15f452281cd33488b9e4

Add missing parameters for jmx4perl check command

fixes #10503

2015-11-05 16:52:50 +00:00 by mfriedrich 4c0b24546687ebc7bdbea0a6cbdffb9bd440ea45

Update AUTHORS

refs #10503
icinga-migration commented 9 years ago

Updated by mfriedrich on 2015-10-31 12:16:38 +00:00

Please add these parameter to the documentation as well, and attach a git patch :) Details over here: https://wiki.icinga.org/display/community/Contribute+Icinga+2+ITL+Plugin+Check+Command+Definitions

icinga-migration commented 9 years ago

Updated by mfriedrich on 2015-10-31 12:16:50 +00:00

icinga-migration commented 9 years ago

Updated by mfriedrich on 2015-10-31 12:17:00 +00:00

icinga-migration commented 9 years ago

Updated by hostedpower on 2015-11-02 15:04:03 +00:00

Hi here is a patch, I hope it's ok! :)

icinga-migration commented 9 years ago

Updated by mfriedrich on 2015-11-04 10:30:07 +00:00

icinga-migration commented 9 years ago

Updated by mfriedrich on 2015-11-05 16:52:25 +00:00

The git patch did not apply to the current master due to some whitespace issue. Please use tabs as indent in the future. Please use your real name and email address next time. I've taken the liberty now to extract that from your Icinga account.

Thanks, Michael

icinga-migration commented 9 years ago

Updated by hostedpower on 2015-11-05 16:55:03 +00:00

Applied in changeset 773e398799900765b13f15f452281cd33488b9e4.

icinga-migration commented 9 years ago

Updated by hostedpower on 2015-11-06 08:00:07 +00:00

Thx a lot for fixing my patch and applying it. I will try to avoid these issues in the future!

icinga-migration commented 9 years ago

Updated by mfriedrich on 2015-11-12 15:34:46 +00:00