search

Icinga / icingaweb2-module-nagvis

NagVis integration into Icinga web 2
GNU General Public License v2.0
39 stars 22 forks source link

Upgrading to NagVis >= 1.9.42 breaks this module because of missing implementation of usesBcrypt($username) #59

Closed mj84 closed 2 months ago

mj84 commented 2 months ago

The NagVis PHP class CoreAuthModule in NagVis 1.9.42 and above now includes an abstract function usesBcrypt($username).

This method must be implemented in this module's CoreAuthModIcingaweb2 which extends CoreAuthModule, otherwise PHP will complain about abstract methods being used.

Since this method is used to improve password hashing, this should be easy to solve, because authentication is handled by Icingaweb2 in our case and NagVis doesn't need to worry about hashing.

I worked up a quick fix for this problem by adding this method (which just returns false). I'll prepare a PR to close this issue.

Cheers