search

IdeaSpaceVR / IdeaSpace

:sunglasses: Create interactive 3D and VR web experiences for desktop, mobile & VR devices.
MIT License
421 stars 118 forks source link

why was the composer.json stripped from this repository? #66

Open vesper8 opened 5 years ago

vesper8 commented 5 years ago

I see that this project is built on top of a pre-release version of Laravel 5.2

I find it odd that the composer.json was removed and that the installation procedure is a bit unorthodox requiring the download a zip that includes the vendor folder rather than the usual git clone and composer install

This makes it more difficult to build on top of this project and improve it, possibly updating Laravel to a newer version and adding more dependencies to forks as the need arises

Any chance you might include the composer.json or post the contents of it here please?

Thanks

weddingdj commented 5 years ago

I modified Laravel in order to get rid of the necessity to set the web root in the public directory. The reason is that I wanted IdeaSpaceVR as easy to install for anybody as Wordpress is: download a zip, unpack it, use it on a shared hosting provider immediately, without configuring your web server.

Do you have an idea how to achieve both - composer install and my solution?

vesper8 commented 5 years ago

well.. as someone who's been developing with Laravel for nearly 3 years, I feel like having the web root in /public is safe and wise and exactly how it should be.. in fact for the last few years when ever I install Wordpress somewhere I also put in the public folder.. this way you can put things in the root that should never be accessible to anyone visiting the web.. just good practice if you ask me

I see you've simply moved the index.php to the root. I guess Laravel doesn't really care where the index.php is. Even if you had an .env file and a composer.json and ran composer install, you could still have the index.php in the root and as long as you point it there in your nginx/apache/cpanel then all should be fine

I've seen a few other projects do it like you are doing.. as a developer I'm not a fan of your approach but I guess the best solution would be to offer both installation procedures.. the 'easy' one which is to download the zip.. and the 'developer' one which is to git clone / composer install

All your "setup" variables could also be populating the .env file, still relying on the .env file as a store for the values but allowing the convenience of a setup wizard for the less tech-savvy crowd

Maybe that could be the way forward then?

One of the benefits of doing it this way is that people can check out your dev-master branch and don't have to wait for you to package a new release to get the latest fixes/features

It also makes it easier for yourself to keep up to date with the latest Laravel enhancements.. speaking of which.. 5.2? Any plan to upgrade to 5.7 for the last 2 and a half year's worth of goodies? There are so many!

Anyway keep up the fine work.. looking forward on having a deeper look at what you've done here.. I'm very interested in starting to develop for VR/AR/XR and Aframe seems like the way to go and this project of yours might be my how I get my toes wet!

weddingdj commented 5 years ago

Thank you for your ideas and suggestions. I think to offer both ways to install it would be best. If you want you could do a PR?

I know that I should upgrade slowly to a newer Laravel release, but I am currently developing one theme at a time in order to prove what IdeaSpaceVR can do. At this point in time I feel this is more important than having the latest features of Laravel.