Ideas2IT / cordova-aes256

MIT License
13 stars 20 forks source link

Capacitor support #23

Open BorntraegerMarc opened 5 years ago

BorntraegerMarc commented 5 years ago

Hi

I wanted to get feedback from the authors & maintainers whether you are open (or even planning?) to support ionic's capacitor? https://capacitor.ionicframework.com/docs/plugins

I think generally Cordova plugins should work out of the box and I will test in the following weeks whether there are any issues. But wants to get some feedback from you guys :)

Now since capacitor is stable (https://blog.ionicframework.com/announcing-capacitor-1-0/) it would be a good time to start thinking about it.

Looking forward to get feedback :)

pandiarajan-i2i commented 5 years ago

Hi @BorntraegerMarc ,

We have already done some groundwork on the ionic's capacitor. Also, we use it in the local development project. Hopefully, once @praveenraji2i has done with the siwft4 support, this plugin will become stable with respect to Xcode/Swift version then we can roll out a new version of the plugin with the capacitor. We do some analysis on the migrations/plugin upgrades.

Thanks for using this library and your contributions.

BorntraegerMarc commented 5 years ago

Glad to hear 🙂

So let's maybe keep this issue as a feature request then.

Happy to help

BorntraegerMarc commented 4 years ago

any update here? :)

as said: I'm happy to help out with my team as long as we're aligned what needs to be done :)

pandiarajan-i2i commented 4 years ago

Thanks, @BorntraegerMarc.

@suriyakumarcs has already completed the development for the capacitor support. He is facing some build issues in the "Android" platform and try to resolve them.

We are determining the ways of updating existing repo or creating a separate repository.

Meanwhile, I will share the repo link with you and you can contribute to it.

Thank you for your interest and contributions.

suriyakumarcs commented 4 years ago

@BorntraegerMarc cc: @pandiarajan-i2i Added capacitor support and pushed into a new branch here:https://github.com/suriyakumarcs/cordova-aes256/tree/feat/capacitor

Needs to be done: Need to add thread support in capacitor plugin.

Troubleshooting:
For Errors like error: package com.ideas2it.aes256 does not exist It requires manually to add the following code in capacitor.build.gradle file of the app where this plugin going to be use like the following apply from: "../capacitor-cordova-android-plugins/cordova.variables.gradle" dependencies { implementation project(':capacitor-plugin-aes256-encryption') }

For Reference have added the sample screen-shot:

Screenshot from 2019-11-25 16-31-47

dupiesdupreez commented 2 years ago

From and including: Friday, 24 May 2019 To, but not including Thursday, 27 January 2022

Result: 979 days It is 979 days from the start date to the end date, but not including the end date. Or 2 years, 8 months, 3 days excluding the end date. Or 32 months, 3 days excluding the end date.

We can all assume Capacitor support is not happening

ijavid commented 1 year ago

Just for record, the Capacitor wrapper is available https://ionicframework.jp/docs/v5/native/aes-256/