Igalia / acacia

Library for inspecting accessibility APIs
https://igalia.github.io/acacia
GNU Lesser General Public License v2.1
8 stars 1 forks source link

Windows: update to use new code style #148

Closed spectranaut closed 7 months ago

spectranaut commented 8 months ago

Please read #147

For example:

  bool IsNull() { return !iface_; }  
  std::string GetProperties();
  std::string get_attributes();
  GroupPosition get_groupPosition();
  std::vector<std::string> GetRelations();
  std::string role();
  long get_states();
  std::vector<std::string> GetStates();

To become:

  bool isNull() { return !iface_; }
  std::string getProperties();
  std::string getAttributes();
  GroupPosition getGroupPosition();
  std::vector<std::string> getRelations();
  std::string role();
  long getStates();
  std::vector<std::string> getStateStrings();

Additionally, the static functions on IANode should be updated from:

  static IANode CreateRootForName(const std::string& name, const int pid = 0);
  static IANode CreateRootForPID(const int pid);

to functions in the module namespace with a slightly different name (per #105):

  IANode findRootIANodeForName(const std::string& name, const int pid = 0);
  IANode findRootIANodeForPID(const int pid);

ALSO in this task, change the interface's "GetProperties" to "toString", per joanie's comment on https://github.com/Igalia/AXAccess/pull/145#issuecomment-2013606844

spectranaut commented 8 months ago

I can do this when I get back from vacation! Unless someone (like Joanie) wants to do it next week.

spectranaut commented 8 months ago

Oh damn, I just realized I can't do this when I'm "back" from vacation, because I won't have my windows computer for that week. @joanmarie .. I wonder if you will have time to do this next week, after your work on the linux APIs is done?

joanmarie commented 8 months ago

@spectranaut: I'm not completely done with the linux API stuff, but I just landed the renaming part of this issue. Moving the find-root functions into the module namespace is still pending.

spectranaut commented 7 months ago

done!