Open alice opened 7 months ago
Hmmm Alice I can't build with these changes, I get the following error:
[build] LINK : fatal error LNK1181: cannot open input file 'C:\Users\spectranaut\repos\AXAccess\build\third_party\ia2\lib\Release\iaccessible2.lib' [C:\Users\spectranaut\repos\AXAccess\build\lib\ia2\build\acacia_ia2.vcxproj]
Before I dig into it -- are you using ninja, by any chance, when on Windows? Or are you just using the msbuild compiler? I switch to ninja at some point and wrote about it in the README, see the "important" here: https://github.com/Igalia/acacia?tab=readme-ov-file#dependencies-1
It's a pain to get the cmake to support both multi configuration generators and single configuration generators, thus the switch to ninja.
Ohhh yeah I missed that :( Sorry for the noise. Geez, Windows is touchy.
Just want to confirm you can build with windows and ninja's before abandoning this PR?
WIN_OUTPUT_DIRECTORY
change is because some thing were ending up inbuild/bin
and some things were ending up inbuild/bin/Release
, but they all need to be in the same directory. This ensures that the VS Code generator doesn't get creative with adding/Release
on the end of things.OUTFILE_DIR
for the Python SWIG target is just because it was weird seeingacacia_ia2PYTHON_wrap.cxx
end up inbuild/bin
- I came across that while trying to fix the above actual problemcmake copy
command out into its own step is because it wasn't running when it was part of theacacia_ia2.node
custom command, and I couldn't figure out why, but this worked.binding.gyp.in
is a temporary fix for a related problem -iaccessible2.lib
ends up inbuild/third_party/ia2/lib/Release
for a Release build, because Visual Studio just tacksRelease
on the end. Obviously this fix won't work for a Debug build, but we're assumingRelease
elsewhere already, so we can fix them all at the same time whenever we fix #178.