search

Igalia / webkit-container-sdk

The all-in-one SDK for WebKit GTK/WPE port development.
MIT License
12 stars 7 forks source link

List libsysprof-capture-4-dev for installation #36

Closed aperezdc closed 3 months ago

aperezdc commented 3 months ago

WebKit uses libsysprof-capture by default to gather runtime profiling data. Currently developer builds use a bundled copy of the library, so provide it in the SDK container to allow switching to always preferring the system-installed copy.

This is needed before we can tackle https://bugs.webkit.org/show_bug.cgi?id=277627

aperezdc commented 3 months ago

As @TingPing pointed out, images/wkdev_sdk/Containerfile calls into Tools/{wpe,gtk}/install-dependencies into the WebKit checkout, so adding the package to the lists used for those scripts would have it installed without needing this patch. Closing, and I will make the corresponding patch for WebKit instead.

TingPing commented 3 months ago

Triggered a new build so it will be added to the image: https://github.com/Igalia/webkit-container-sdk/actions/runs/10202240105

aperezdc commented 3 months ago

Triggered a new build so it will be added to the image: https://github.com/Igalia/webkit-container-sdk/actions/runs/10202240105

Great, thanks!