IgniteUI / igniteui-angular-samples

Ignite UI for Angular demos for all available components and features
https://bit.ly/2L19rhp
36 stars 25 forks source link

Grids Row Conditional Selection demos allow selection for disabled rows #3379

Closed ddaribo closed 1 year ago

ddaribo commented 1 year ago

Description

Due to the following breaking changes the demos do not work as expected and allow selecting the disabled rows:

"rowSelectionChanging event arguments are changed. Now the oldSelection, newSelection, added and removed collections no longer consist of the row keys of the selected elements when the grid has set a primaryKey, but now in any case the row data is emitted." as of version 15.1.0

and

"rowID in the context object of the igxRowSelector is now deprecated and will be removed in future version. Use key property instead." as of version 13.0.0

Steps to reproduce

  1. Grid sample
  2. Tree grid sample
  3. Hierachical grid sample

Result

Disabled rows are selectable.

Expected result

Not being able to select disabled rows.