search

IjzerenHein / firestorter

Use Google Firestore in React with zero effort, using MobX 🤘
http://firestorter.com
MIT License
378 stars 50 forks source link

Breaking changes in Mobx? #8

Closed DennisSchmock closed 6 years ago

DennisSchmock commented 6 years ago

Hi.

Thank you for this great module. I am really enjoying using it in my web-app, saving me a ton of boilerplate.

But after updating Mobx to the newest version it stopped working for me:

Failed to compile. ./node_modules/firestorter/dist/firestorter.module.js 122:12-18 'mobx' does not contain an export named 'extras'.

I have run several test with brand new Create-React-App projects, and the result is the same each time

From package.json firebase": "^4.11.0", "firestorter": "^0.9.3", "mobx": "^4.1.0", "mobx-react": "^5.0.0",

Is it incompatible with Mobx 4?


import {firestoreApp,firebaseApp} from "./db";
import {initFirestorter, Collection} from 'firestorter';
import {observer} from 'mobx-react';

initFirestorter({firebase: firebaseApp}); 

const Tournaments = new Document()

export {Tournaments}
DennisSchmock commented 6 years ago

Ok, there is breaking changes in Mobx4/Mobx-react5 when it comes to Firestorter. Just downgraded Mobx to version 3.4.1 and Mobx-react to 4.4.3 and now firestorter works again.

IjzerenHein commented 6 years ago

Alright thanks for reporting man! I'll take a look at this shortly, for now please use mobx 3.x Cheers

IjzerenHein commented 6 years ago

Just for my own reference: https://github.com/mobxjs/mobx/wiki/Migrating-from-mobx-3-to-mobx-4

DennisSchmock commented 6 years ago

Well, thank you again for your effort with this plugin. It really rocks.

IjzerenHein commented 6 years ago

Hey man, thanks so much for the donation, I really appreciate it! I'm gonna add you to the list of backers. Cheers dude!

IjzerenHein commented 6 years ago

Work in progress, just ran into this issue with mobx 4: https://github.com/mobxjs/mobx/issues/1437

IjzerenHein commented 6 years ago

Hi, I've pushed preliminary support for MobX 4 to the master branch. Still waiting on the previously mentioned issue before I'm gonna release this officially.

DennisSchmock commented 6 years ago

Seems like that did the trick. Great work, and I hope the Mobx team picks up your issue fast :-)

IjzerenHein commented 6 years ago

Hey Dennis, I've just released an official update that supports MobX 4: https://github.com/IjzerenHein/firestorter/releases/tag/v0.10.0

Let me know whether I can close this issue?

cheers