ImagingDataCommons / slim

Interoperable web-based slide microscopy viewer and annotation tool
https://imagingdatacommons.github.io/slim/
Apache License 2.0
118 stars 36 forks source link

Implement Object Class Display on Hover #195

Open pedrokohler opened 6 months ago

pedrokohler commented 6 months ago

it would be great to have the option of hovering over an object and having the class or a class nickname displayed.

show ROI number/details in a tooltip as an option on mouse-over

Implement Object Class Display on Hover

Description

Implement a feature that allows users to hover over an object and display its class or a class nickname. This enhancement will provide users with quick access to important information about objects, improving usability and workflow efficiency.

Acceptance Criteria

  1. When hovering over an object, its class or class nickname should be displayed.
  2. The displayed class information should be easily readable and unobtrusive.
  3. Ensure that the class display feature is responsive and activates promptly upon hovering.
  4. The class display should seamlessly integrate with existing object interaction functionalities.

The viewer currently displays Region of Interest (ROI) number and details in a tooltip upon mouse-click. This feature requires retesting to ensure its functionality extends to all annotations.

From #184

pedrokohler commented 6 months ago

@fedorov

So we'll show the ROI number and the class nickname. Do we need anything else?

fedorov commented 4 months ago

Nothing is shown on mouse click when Slim is deployed in view-only mode (as it is in IDC).

I suggest we should include in the tooltip the same information that is currently shown for that annotation in the right-hand slide panel. What do you think?

fedorov commented 4 months ago

Let's change the deploy configuration for the test instance to be "read only" so we test this feature in the same way as it would appear in IDC deployment. Let's just do the double-click/click for now, and after testing that discuss if we still want to have hover support.

igoroctaviano commented 4 months ago

@fedorov I updated the env https://slim-dmv.web.app/ Now it should be read-only similar to IDC's slim deployment. You can double check the annotation groups or the ROIs and it should open the dialog. After the test let us know if we are going to add the hover tooltip or stick with the double click dialog.

fedorov commented 4 months ago

You can double check the annotation groups or the ROIs and it should open the dialog.

It does - thank you!

pedrokohler commented 3 months ago

You can double check the annotation groups or the ROIs and it should open the dialog. It does - thank you!

@fedorov does this mean that there is no reason to keep this issue open, or should something be developed?

fedorov commented 3 months ago

I reviewed what is available right now.

I think there is a bug or I don't understand something, but I do not think it makes sense to have 3 states for the annotation highlights (yellow, bright blue and pale blue). Is this a bug?

2024-06-10_12-13-33

Second, I think showing ROI information on hover would be very helpful, so let's keep this ticket open.

igoroctaviano commented 3 months ago

I reviewed what is available right now.

I think there is a bug or I don't understand something, but I do not think it makes sense to have 3 states for the annotation highlights (yellow, bright blue and pale blue). Is this a bug?

2024-06-10_12-13-33 2024-06-10_12-13-33

Second, I think showing ROI information on hover would be very helpful, so let's keep this ticket open.

@fedorov Do you think this bug was caused by this change, or is it an unrelated/new issue found in Slim?

fedorov commented 3 months ago

I do not know. Click to show ROI information was not enabled in the past, so I do not have experience using it. We don't have it enabled in the IDC deployment either.

igoroctaviano commented 3 months ago

I do not know. Click to show ROI information was not enabled in the past, so I do not have experience using it. We don't have it enabled in the IDC deployment either.

Could you please share the env, and server used so @pedrokohler or myself can replicate this issue?

fedorov commented 3 months ago

This is the DICOM store: https://healthcare.googleapis.com/v1/projects/idc-dev-etl/locations/us-central1/datasets/idc/dicomStores/annotated_rms-original-and-annotations-wc-temp-20240122/dicomWeb.

I was testing with your https://slim-dmv.web.app/ instance.

igoroctaviano commented 3 months ago

This is the DICOM store: https://healthcare.googleapis.com/v1/projects/idc-dev-etl/locations/us-central1/datasets/idc/dicomStores/annotated_rms-original-and-annotations-wc-temp-20240122/dicomWeb.

I was testing with your https://slim-dmv.web.app/ instance.

@pedrokohler please replicate this issue locally using the master branch. If it's reproducible using master then create a new issue for it and attach the video shared by Andrey. I guess that we have two highlighting here which are only noticeable when testing against SR annotations (one highlight from OpenLayers and another from slim).

fedorov commented 3 months ago

I just noticed this today - maybe this is related, see demo below. I was not aware of this functionality earlier.

2024-06-11_18-04-22