search

Imgur / imgurpython

Official Imgur python client library (deprecated)
MIT License
546 stars 116 forks source link

Adding more Examples in Documentation #25

Closed ueg1990 closed 9 years ago

ueg1990 commented 10 years ago

I am creating the pull request now. You do not have to merge it. You can review the docs as I add them and i will make the changes if there are any. Like you said, include multiple examples per PR.

ueg1990 commented 10 years ago

Hey Jasdev, what kind of example were you referring to for the gif-related searches?

ueg1990 commented 9 years ago

Why do you allow users to create albums without logging in? if you do not allow them add images to an album without logging in, might as well make sure user is logged in while creating an album. On the website, there is no means of creating an album without logging in

jasdev commented 9 years ago

Anonymous albums can indeed be updated without logging in, this step must be taken upon image upload (http://api.imgur.com/endpoints/image#image-upload) :+1:

ueg1990 commented 9 years ago

Hey @Jasdev if you think current examples are good to be added, can you merge this pull request. My created pull request on my master branch but i want to create a new pull request for documentation examples on a separate branch instead of the master. Let me know what you think.

jasdev commented 9 years ago

Hey Usman, thanks so much for adding this documentation! Thinking about it, we should probably move all examples to a separate markdown file and link to them from the primary README to avoid it becoming too large. This will also help with future pull requests :smile:

ueg1990 commented 9 years ago

So i just create pull request with new markdown and add the examples there?

jasdev commented 9 years ago

Yep! If we could also migrate your previous examples that'd be perfect :+1: