ImpactDevelopment / ImpactIssues

Please use this repo to report bugs and request features
https://impactclient.net/
218 stars 36 forks source link

No SRP doesn't work #2918

Open FurriousFox opened 3 years ago

FurriousFox commented 3 years ago

Describe the bug When turned No SRP on, it still triggers this event with "DECLINED"

To Reproduce Steps to reproduce the behavior:

  1. Enable No SRP
  2. Join a server with a (bukkit/spigot/paper) plugin containing this code (this is working code):
    @Override
    public void onEnable() {
    getServer().getPluginManager().registerEvents(this, this);
    }

    @EventHandler
    public void PlayerJoinEvent(PlayerJoinEvent event)
    {
    Player player = event.getPlayer();
    player.setResourcePack("http://pack.maloweb.com/willpack7.zip"); //this is an example resource pack
    }

    @EventHandler
    public void PlayerResourcePackStatusEvent(PlayerResourcePackStatusEvent event){
        if (event.getStatus().toString()=="DECLINED") {
            event.getPlayer().kickPlayer("You didn't accept the resource pack!");;  
        }
    }
  1. Click on "no" when asked if resource pack has to be installed.
  2. You're now kicked because not accepting the resource pack

Expected behavior I expected that it would return "ACCEPTED" not "DECLINED"

Screenshots None

Game output ``` You didn't accept the resource pack! ```
Additional Client Info - Impact Version: 4.9 - Using Optifine? Yes - Using LiteLoader? No - Enabled mods: No SRP - Operating System: Windows 10 64bit

Additional context None

5HT2 commented 3 years ago

holy shit people are actually making valid bug reports??