search

ImpactDevelopment / Installer

The installer
https://impactclient.net/
Other
80 stars 13 forks source link

MultiMC support for the Impact installer is broken #118

Open ironminer888 opened 4 years ago

ironminer888 commented 4 years ago

Describe the bug The MultiMC mode for the current version of the Impact installer doesn't create an instance of Minecraft with Impact inside of MultiMC.

To Reproduce Steps to reproduce the behavior:

  1. Launch the installer
  2. Select "MultiMC Instance as install type"
  3. Click the Install button
  4. No MultiMC instance for Impact is created, but the installer says the installation succeeded anyways

Expected behavior I expected an instance to be created in MultiMC.

Screenshots The installer says everything went fine, but... image image there's no folder for the Impact instance, and image MultiMC also says there's no instance.

Game output ``` N/A ```
Crash report ``` N/A ```
Additional Client Info - MultiMC Version - 0.6.11 - Impact Version: installer 0.9.3 - Using Optifine? N/A - Using LiteLoader? N/A - Enabled mods: N/A - Operating System: Windows 10 64-bit

Additional context I've already tried several potential fixes, including unblocking the installer in my file explorer, unsetting MultiMC's files from read-only, moving my MultiMC to the same drive as regular Minecraft. Impact installs and runs fine through the vanilla launcher image, but MultiMC refuses to cooperate.

ghost commented 4 years ago

Installed perfectly fine for me, CNR.

5HT2 commented 4 years ago

@tstephenson888 try making a regular instance for the same version you selected in the installer, launch it so the assets are downloaded, and then use the installer

ironminer888 commented 4 years ago

I just tried creating a 1.15.2 instance and launching it before installing is as per @l1ving's request, it didn't work. It still boots into vanilla Minecraft.

5HT2 commented 4 years ago

🗿

oblivion2k commented 4 years ago

Same issue, I've got the .minecraft folder open that multiMC is using for impact, I put that launcher directory into the installer, and I can see from the date modified tab in explorer that the impact installer is making no changes to the directory, even though it completes "successfully"

Installing following the steps for old versions of Impact Installer gives an error in the console

Instance update failed because: Game update failed: it was impossible to fetch the required libraries. Reason: Job 'Libraries for instance Impact' failed to process: https://s3.amazonaws.com/Minecraft.Download/versions/1.12.2-Impact_4.9.1/1.12.2-Impact_4.9.1.jar

Moving the Impact version entry we added to the top of the version list above LWJGL-2(What is this?) and Minecraft lets the game launch, but it's completely vanilla. I can even see the Impact library .jars being referenced in the console, but as far as I can tell, the instance is completely vanilla.

ghost commented 3 years ago

Try using the java installer. It works on windows just make sure u have java installed(U want it anyway if u play minecraft)

pomtom44 commented 3 years ago

Can confirm same problem with my installer. fresh 1.16.4 install in MultiMC, downloaded both exe and jar for nightly installer tried to install to the multiMC root, the instance folder, and the .minecraft folder installer says impact installed, but no mods installed into any of the folders, and when launching, no mods are loaded