ImperialCollegeLondon / SWMManywhere

SWMManywhere is used to derive and simulate a sewer network anywhere in the world

https://imperialcollegelondon.github.io/SWMManywhere/

BSD 3-Clause "New" or "Revised" License

5 stars 1 forks source link

codecov issue on release #336

Closed barneydobson closed 3 weeks ago

barneydobson commented 3 weeks ago

Description

Looks like publish.yml is crashing on release because it doesn't have codecov secret - would this fix it?

Also there's that thing we need to do for releases that failed in some way - but I can't remember what it's called

Fixes # (issue)

Type of change

[ ] Documentation (non-breaking change that adds or improves the documentation)
[ ] New feature (non-breaking change which adds functionality)
[ ] Optimization (non-breaking, back-end change that speeds up the code)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Breaking change (whatever its nature)

Key checklist

[ ] All tests pass (eg. python -m pytest)
[ ] The documentation builds and looks OK (eg. python -m sphinx -b html docs docs/build)
[ ] Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

[ ] Code is commented, particularly in hard-to-understand areas
[ ] Tests added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

barneydobson commented 3 weeks ago

As in - the codecov prevented the publish actions from completing? So does that mean I have to ... yank? (was it yank?) it?

dalonsoa commented 3 weeks ago

It should not fail, but if it does, the whole workflow would be interrupted and nothing published to PyPI - and therefore nothing to yank.