ImperialCollegeLondon / SWMManywhere

SWMManywhere is used to derive and simulate a sewer network anywhere in the world
https://imperialcollegelondon.github.io/SWMManywhere/
BSD 3-Clause "New" or "Revised" License
5 stars 1 forks source link

Planetary computer precipitation #339

Open barneydobson opened 2 weeks ago

barneydobson commented 2 weeks ago

Description

Update to use planetary computer

Fixes #20

Related to #55

Discussion

This works, but there is a bit of an issue in that I think ERA5 is actually 3 hour rolling average at an hourly timestep. I mean I guess it is better than nothing for global coverage... but it's probably not ideal.

Type of change

Key checklist

Further checks

codecov-commenter commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 6.66667% with 14 lines in your changes missing coverage. Please review.

Project coverage is 87.50%. Comparing base (fb919bc) to head (67b6914). Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/swmmanywhere/prepare_data.py 6.66% 14 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #339 +/- ## ========================================== - Coverage 87.77% 87.50% -0.28% ========================================== Files 22 22 Lines 2217 2224 +7 Branches 280 281 +1 ========================================== Hits 1946 1946 - Misses 194 201 +7 Partials 77 77 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.