ImperialCollegeLondon / wsi

WSIMOD is a software for simulating water quality and quantity
https://imperialcollegelondon.github.io/wsi/
BSD 3-Clause "New" or "Revised" License
13 stars 2 forks source link

Remove customise a node tutorial #114

Closed barneydobson closed 1 month ago

barneydobson commented 1 month ago

Remove the tutorial, fix a formatting issue. New recommendations on node customisation will be given by #111

Fixes #113

Discussion

barneydobson commented 1 month ago

@dalonsoa any idea what's causing the tests to fail? this seems to be across multiple repos that this has started happening (and if I rerun old tests that were passing they now fail). I fixed it on another repo with below, but that's just chatgpt whatever, I don't actually know what is happening. image

dalonsoa commented 1 month ago

Yep. pre-commit action is failing everywhere due to recent updates to "something". Unclear what. The maintainer is pretty rude, so we are all pretty pissed.

In any case, being this repo public, you don't need to use pre-commit action. Just delete that action altogether and I'll setup pre-commit.ci, as we did with SWMManywhere.

dalonsoa commented 1 month ago

I've just done it myself. It should all work, now, and run pre-commit via pre-commit.ci.

barneydobson commented 1 month ago

Yeah - I mean i know that nothing is lost on git, but I can envisage it being useful at one point or another (and if it's on the repo it will be somewhat findable). If you think that makes no sense then see description suggestion of a guide archive?

dalonsoa commented 1 month ago

Sorry, I missed that part of the description. I'd personally ditch the file altogether. If it is not best practice, we should not even show how it is done. But up to you.

If you do so, put them in an archive subfolder and, within, a README.md file explaining this.

barneydobson commented 1 month ago

OK tbh it may cause more harm than good RE confusion