In-Touch / laravel-newrelic

Laravel NewRelic ServiceProvider
173 stars 48 forks source link

Config file should have warning about the default settings #34

Open trm42 opened 8 years ago

trm42 commented 8 years ago

Thanks for the awesome package.

I stumbled upon a problematic situation with Newrelic as I ended up using the default values for 'name_provider' (=> '{uri} {route}') in the config. It's nice way to use NR with Laravel, but in high-volume + lots of changing uris, we got contacted by Newrelic and they informed us that there's "unusually large number of unique transaction names".

So how about adding additional warning or suggestion to the config file which says something like "If you have lots of different uris, drop the {uri} from the config as Newrelic doesn't recommend over 1000 transaction names"? Probably saves some work from people using your package and from Newrelic as well :)