InFact-coop / building-exploratory

App for accessing the listed buildings in the borough of Islington
MIT License
1 stars 0 forks source link

Mapbox integration #14

Closed jessicasalmon closed 7 years ago

jessicasalmon commented 7 years ago

relates #10

sohilpandya commented 7 years ago

not completely ready, but definitely worth you having a look @emilyb7

screen shot 2017-11-21 at 18 11 55

emilyb7 commented 7 years ago

Here's the error I'm getting when I start the server btw.

[1] module.js:487
[1]     throw err;
[1]     ^
[1]
[1] Error: Cannot find module 'fast-deep-equal'
[1]     at Function.Module._resolveFilename (module.js:485:15)
[1]     at Function.Module._load (module.js:437:25)
[1]     at Module.require (module.js:513:17)
[1]     at require (internal/module.js:11:18)
[1]     at Object.<anonymous> (/Users/emilybertwistle/infact/building-exploratory/node_modules/ajv/lib/compile/resolve.js:4:13)
[1]     at Module._compile (module.js:569:30)
[1]     at Object.Module._extensions..js (module.js:580:10)
[1]     at Module.load (module.js:503:32)
[1]     at tryModuleLoad (module.js:466:12)
[1]     at Function.Module._load (module.js:458:3)
[1] npm ERR! code ELIFECYCLE
[1] npm ERR! errno 1
[1] npm ERR! building-exploratory@1.0.0 start-front: `NODE_PATH=src/ react-scripts start`
[1] npm ERR! Exit status 1
[1] npm ERR!
npm ERR! Failed at the building-exploratory@1.0.0 start-front script.
[1] npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
[1]
[1] npm ERR! A complete log of this run can be found in:
[1] npm ERR!     /Users/emilybertwistle/.npm/_logs/2017-11-21T21_34_54_195Z-debug.log
[1] npm run start-front exited with code 1
[0] listening on localhost:4000
sohilpandya commented 7 years ago

hey @emilyb7 we will look at these, most of it is that one file which we need to refactor, but that error you are getting is really weird. will check it out. :)

Thanks.

emilyb7 commented 7 years ago

ok FINALLY got this working ✨🎉

npm was doing weird things. There are still a few unresolved things here, but don't want to block this any more :)

the mapbox ui looks really nice!

jessicasalmon commented 7 years ago

thanks @emilyb7, great that npm isn't doing weird things anymore 🎉

responded/ made changes to your latest comments, and will merge in now.