search

InFact-coop / building-exploratory

App for accessing the listed buildings in the borough of Islington
MIT License
1 stars 0 forks source link

WIP Styling #24

Closed sohilpandya closed 6 years ago

sohilpandya commented 7 years ago

Hey @emilyb7,

we've hit a bit of a roadblock on a particular issue. We think it's react related.

We are using the mapbox react gl library and a component called Feature.

The problem is to do with the setState. If we remove SetState from line 22 & 27 in MapLayer.js, we see normal console logs in the developer tools. BUT if we uncomment these, you'll see the console logs increase in frequency and the marker on the map flicker.

Please have a look when you get a chance, all things are happening in MapLayer.js file.

Thanks!

sohilpandya commented 6 years ago

@emilyb7 can you please take a look it is HUGE, but we have done a lot of work on this, minor parts remaining for the perfect look hopefully. :)

emilyb7 commented 6 years ago

oh one more thing! check if there're any dependencies you can remove from the package.json!

sohilpandya commented 6 years ago

@emilyb7 merging in, but left comments here https://github.com/InFact-coop/building-exploratory/issues/31

THanks X