Input file (breaking) errors?

IndEcol / IE_data_commons

Code and documentation for a commons of structured industrial ecology data

MIT License

22 stars 2 forks source link

Input file (breaking) errors? #12

Closed nheeren closed 5 years ago

nheeren commented 6 years ago

The following files may have have errors and require discussion:

unit_denominator is 1. What does that mean? This unit does not exist in the DB.
- 1_UPI_USLCI_Aluminum_cold_rolling_at_plant.xlsx
- 1_UPI_USLCI_Chainsawing_delimbing.xlsx
- 1_UPI_USLCI_Electricity_lignite_coal_at_power_plant.xlsx

List not final yet.

stefanpauliuk commented 6 years ago

To manage the diversity of possible units, they are split into nominator and denominator. E.g., when someone wants to enter data in 'km/yr', they don't have to define a new unit, instead, they point to 'km' for the nominator and 'yr' for the denominator. If the unit is simple, like 'Mt' for a stock, the denominator is simply set to 1. Since the data type is VARCHAR, this turns into '1' in the DB. So just look for '1' when unit nominator or denominator is integer 1.

nheeren commented 5 years ago

I suppose it needs to be added to the unit table though

nheeren commented 5 years ago

implemented lookup on multiple columns. unit table now contains 1 and p for piece