search

IndEcol / IE_data_commons

Code and documentation for a commons of structured industrial ecology data
MIT License
22 stars 2 forks source link

Column `dataset_version` in table `datasets` accepts only 30 characters #22

Closed nheeren closed 5 years ago

nheeren commented 5 years ago

The column dataset_version in table datasets is defined as varchar(30). Therefore the string "SSP Public Database (Version 1.1)" from the datafile 2_P_SSP_Database_32R_Future.xlsx is not accepted.

I changed the string to "SSP Public Database (Ver 1.1)" for now.

Not sure how to proceed for the future. We can either

  1. change the the DB schema definition to accept longer strings,
  2. (manually?) ensure that input files have conforming strings or
  3. implement a check in IEDC_tools.

What's your opinion @stefanpauliuk ?

nheeren commented 5 years ago

Same for files 1_F_PPPGDP_SSP_Database_32R_History.xlsx, 6_SHA_Urbanisation_SSP_Database_32R_History, 6_SHA_Urbanisation_SSP_Database_32R_Future, 2_P_SSP_Database_32R_History.xlsx.

stefanpauliuk commented 5 years ago

SSP Public Database (Ver 1.1) is a good fix! Don't think that we need to allow more than 30 characters here.