IndEcol / IE_data_commons

Code and documentation for a commons of structured industrial ecology data
MIT License
22 stars 2 forks source link

Errors in November upload files #24

Closed nheeren closed 4 years ago

nheeren commented 4 years ago

The new files in 'NEW_TABLE_2' contain errors that need to be resolved before the scripts can process them.

stefanpauliuk commented 4 years ago

'Data layer' should be "Misc. units", with lower case u.

nheeren commented 4 years ago

Could you fix those files? If you do it within the next hour I can give it another go.

stefanpauliuk commented 4 years ago

The classification with name YSTAFDB_material_groups exists under id 41 in the review database. There are 11 classf. with id from 37 to 47, which all start with YSTAFDB

nheeren commented 4 years ago

OK. Strange why the script doesn't find them. Will investigate.

stefanpauliuk commented 4 years ago

Shall I still add the correct layer to the files in the dropbox? Can do that now, no problem.

nheeren commented 4 years ago

I believe the problem is rather that D26:D49 must correspond to F12:I21. Would you agree?

stefanpauliuk commented 4 years ago

Oh yes... Probably got confused by my own template. Will check and notify you once the files are fixed.

stefanpauliuk commented 4 years ago

Fixed all YSTAFDB files. Please try again!

nheeren commented 4 years ago

6_MIP_YSTAFDB_MetalUseShares_v1.0 has Values not found in classification_items, i.e. 2010-2012 and 2008

nheeren commented 4 years ago

Shouldn't aspect_1 in 6_CR_YSTAFDB_criticality_2019_v1.0.xlsx be 38?

nheeren commented 4 years ago

Shouldn't aspect_1 in 6_CR_YSTAFDB_criticality_2019_v1.0.xlsx be 38?

Yes (see updates in top post)

stefanpauliuk commented 4 years ago

6_MIP_YSTAFDB_MetalUseShares_v1.0 has Values not found in classification_items, i.e. 2010-2012 and 2008 --> The corresponding classification id is 14, not 9. I changed the data template file, please try again!

stefanpauliuk commented 4 years ago

Is 6_URB_MetabolismOfCities_Jan2019_DOI_7326485.v1 OK?

nheeren commented 4 years ago

Thanks for the fixes. One last dataset remaining!!

6_URB_MetabolismOfCities_Jan2019_DOI_7326485.v1.xlsx: Duplicate entry '10055-Natural gas' for key 'UC_classification_items' Any ideas?

stefanpauliuk commented 4 years ago

Hm. This is a custom classification created on the spot. Guess you already use the set-command to only enter unique classification items...

Will then update the dataset sizes tomorrow, make the mysql dump backup, and post the whole thing on Friday! :)))

nheeren commented 4 years ago

Found it! Again lower-case issues...

New problem: The following unit is not in units table: {1, 'HDD', 'kt'}

stefanpauliuk commented 4 years ago

1 is strange, because it is in there. Maybe as '1'? kt runs under Gg, will modify template accordingly. I overlooked HDD, will add it now.

nheeren commented 4 years ago

Thank you! Yeah 1 is weird. I thought I had fixed that ages ago. Checking...

stefanpauliuk commented 4 years ago

HDD is now in, kt changed to Gg in template.

nheeren commented 4 years ago

'Gg COD', 'Gg BOD' do not exist, however. Only kt.

nheeren commented 4 years ago

Changed them to kt COD and kt BOD. Now stuck with 'day'.

stefanpauliuk commented 4 years ago

day should be 'd'.

stefanpauliuk commented 4 years ago

Sorry for the kt BOD... that was the find and replace fix impact that I overlooked.

nheeren commented 4 years ago

🚀 We made it! 6_URB_MetabolismOfCities_Jan2019_DOI_7326485.v1 is online. Thanks!!

stefanpauliuk commented 4 years ago

Wunderful! Thanks you so much Niko!!!