Closed nheeren closed 6 years ago
Another big benefit, of course, would be version control, i.e. quickly seeing the changes that were made / proposed
Initially we thought about keeping both. The excel files are in the repository already and I am supposed to upload the .sql files also. Somehow I missed it. Will do it asap. If you want, feel free to do it also.
If we want to keep both, its better to create two sub-folders (one for .xlsx files and other one is for .sql files).
Hmm. That adds reduncdancy, which is maybe unnecessary. Say, I want to add a constraint on a particular column, will I need to make changes to both files? What is the benefit of having xlsx files?
I am definitely in favour of dropping the xlsx in places where there is not much formatting to be done, like table definitions. For more complicated files, we can keep Excel-compatible csvs (with ; as separator, have them already now in the IEDC_Classficition_fill folder) that are both csv and thus version-manageable and Excel-editable, which clearly is a great advantage.
Ok, so we agree to move to .sql files in mySQL_Create
and close this issue?
Will @Mahadi21 be able to do that?
Yes, sure.. I can do that.
thanks!
Related to issue https://github.com/IndEcol/IE_data_commons/issues/4, I would like to propose to use actual DDL /
.sql
scripts instead of.xlsx
files in https://github.com/IndEcol/IE_data_commons/tree/master/mySQL_Create An example forprovenance.xlsx
/provenance.sql
:This would be clearer and more portable. I think @Mahadi21 needs to create these commands anyway and he could simply store them in a text file with the
.sql
ending. These can then be executed by different tools.