Indicia-Team / drupal-8-module-iform

Drupal 8 modules for Indicia
0 stars 2 forks source link

Hide option to redetermine to a master list when there isn't one #11

Closed JimBacon closed 1 year ago

JimBacon commented 1 year ago

The iform/client_helpers/ElasticsearchReportHelper.php::verificationButtons() function includes support for redetermination. In conjunction with iform/media/js/indicia.datacomponents/jquery.idc.verificationButtons.js, the redetermination is done from the same species list that was used when submitting the record.

The function requires there to be a master species list and offers to switch to redetermination from the master list when it differs from the list that the original record was made against.

It is not the case that a master list is always available. Needs fixing to allow user to specify there is no master list, preventing the option to switch to a master list from being displayed.

Relates to https://github.com/BiologicalRecordsCentre/ABLE/issues/457#issuecomment-1708486339

JimBacon commented 1 year ago

Fixed in iForm v8.18.3