search

InfiniTimeOrg / InfiniTime

Firmware for Pinetime smartwatch written in C++ and based on FreeRTOS
GNU General Public License v3.0
2.64k stars 903 forks source link

Short ref doesn't appear in CI builds #1842

Open Commenter25 opened 10 months ago

Commenter25 commented 10 months ago

Verification

What happened?

When checking the About or Firmware pages, if running a build from GitHub CI, there will be no short ref

What should happen instead?

There should be one

Reproduction steps

  1. Download and install a release build
  2. Go to the about page and see a commit reference next to short ref (for 1.13, this is 5f3acfad)
  3. Download and install a CI build (this is the 1.13 commit)
  4. Go to the about page and notice a distinct lack of a short ref

Version

v1.13.0

Companion app

Gadgetbridge v0.75.1

jensonb commented 10 months ago

I also noticed this issue as well when building myself. Where does the release build actually come from?

Either way, the git hash is retrieved during the following portion of the build: https://github.com/InfiniTimeOrg/InfiniTime/blob/5f3acfadd24fcf8f0ef31a75c36180585b1c88c4/CMakeLists.txt#L38-L57 https://github.com/InfiniTimeOrg/InfiniTime/actions/runs/5364794676/job/14523852337#step:4:55 image

the git command seems to be failing