search

Infocatcher / Private_Tab

Adds private tabs, restartless extension for Firefox (20.0+) and SeaMonkey (2.17+)
https://addons.mozilla.org/addon/private-tab/
Other
86 stars 20 forks source link

Wrong/Useless private tab message in non-private tab #177

Closed rugk closed 9 years ago

rugk commented 9 years ago

Right after your last update this issue occured.

Steps to reproduce:

  1. Open a new normal window. (e.g. by dragging and dropping a tab out of the actual window)
  2. Open a normal (=non-private) tab as you normally would.
  3. The issue occurs. Firefox doesn't display about:newtab correctly, but it shows this (quite useless) message: privatetab_wrongprivatetabmessage

There it states "correctly" that the tab is not a private window, but prompts to open a private window. BTW exactly the same message is also displayed for private tabs, so that's strange too.

Windows 7 Firefox 38.0.1 Plugin Version: 0.1.7.4

Infocatcher commented 9 years ago

Looks like I found a reason: 29c43a5ed62bce0b6cd9814bf2606717f27f79e8

rugk commented 9 years ago

Okay, great. :+1: So you can close the issue if the bug is fixed.

Infocatcher commented 9 years ago

Oh, to be really sure... Please try test version: private_tab-0.1.7.6pre-fx-sm.xpi (source code).

Rikk commented 9 years ago

Oh long time having this bug, never figured out what plugin was causing it.

For some time I used layers.offmainthreadcomposition.enabled = false as workaround, but was not worth due to some other quirks.

That test version looks good, thanks!

rugk commented 9 years ago

I can confirm that it's fixed with the version you provided. (fixed by 29c43a5ed62bce0b6cd9814bf2606717f27f79e8)