search

Infocatcher / Private_Tab

Adds private tabs, restartless extension for Firefox (20.0+) and SeaMonkey (2.17+)
https://addons.mozilla.org/addon/private-tab/
Other
86 stars 20 forks source link

Broken in Firefox 46.0a1+ due to removed legacy array/generator comprehension #203

Closed Infocatcher closed 8 years ago

Infocatcher commented 8 years ago

See https://bugzilla.mozilla.org/show_bug.cgi?id=1220564

SyntaxError: missing ] after element list .../extensions/privateTab@infocatcher.xpi!/bootstrap.js:1561:22

    forgetClosedTabs: function(window) {
        var closedTabs = [i for(i in this.getClosedPrivateTabs(window))];
Infocatcher commented 8 years ago

Test version: private_tab-0.1.9.1pre-fx-sm.xpi (source).

sylveon commented 8 years ago

Is it possible to put pre-release versions on AMO on the beta channel? I can't install it, it isn't signed.

Spyneur commented 8 years ago

Hello Charlesmilette,

Here a tip for no-signed addon :

Now you can install EVERY addons even if isn't signed :p

sylveon commented 8 years ago

Thanks @Spyneur.

This preview stills doesn't works for me on latest Nightly:

08:09:30,575 unsafe CPOW usage forbidden PrivateBrowsingUtils.jsm:49:0
08:09:34,617 unsafe CPOW usage bootstrap.js:4017:17
08:09:34,618 1454159374618  addons.xpi  WARN    Exception running bootstrap method shutdown on privateTab@infocatcher: Error: unsafe CPOW usage forbidden (resource://gre/modules/PrivateBrowsingUtils.jsm:49:5) JS Stack trace: pbu_privacyContextFromWindow@PrivateBrowsingUtils.jsm:49:5 < privateTab.getPrivacyContext@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/Charles/AppData/Roaming/Mozilla/Firefox/Profiles/Charles/extensions/privateTab@bootstrap.js:3994:10 < privateTab.getTabPrivacyContext@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/Charles/AppData/Roaming/Mozilla/Firefox/Profiles/Charles/extensions/privateTab@bootstrap.js:4030:10 < privateTab.isPrivateTab@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/Charles/AppData/Roaming/Mozilla/Firefox/Profiles/Charles/extensions/privateTab@bootstrap.js:4033:24 < privateTab.destroyWindow/<@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/Charles/AppData/Roaming/Mozilla/Firefox/Profiles/Charles/extensions/privateTab@bootstrap.js:503:37 < privateTab.destroyWindow@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/Charles/AppData/Roaming/Mozilla/Firefox/Profiles/Charles/extensions/privateTab@bootstrap.js:501:4 < privateTab.destroy@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/Charles/AppData/Roaming/Mozilla/Firefox/Profiles/Charles/extensions/privateTab@bootstrap.js:75:4 < shutdown@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/Charles/AppData/Roaming/Mozilla/Firefox/Profiles/Charles/extensions/privateTab@bootstrap.js:29:2 < this.XPIProvider.callBootstrapMethod@XPIProvider.jsm:4658:9 < this.XPIProvider.updateAddonDisabledState@XPIProvider.jsm:4777:13 < AddonWrapper.prototype.userDisabled@XPIProvider.jsm:7072:9 < set_userDisabled@extensions.xml:1072:11 < oncommand@about:addons:1:1
08:09:34,625 Could not read chrome manifest 'file:///C:/Program%20Files/Nightly/chrome.manifest'.
08:09:34,646 Use of nsIFile in content process is deprecated. Content.js:23:17
08:09:37,319 unsafe CPOW usage bootstrap.js:4017:17
08:09:37,320 1454159377320  addons.xpi  WARN    Exception running bootstrap method startup on privateTab@infocatcher: Error: unsafe CPOW usage forbidden (resource://gre/modules/PrivateBrowsingUtils.jsm:49:5) JS Stack trace: pbu_privacyContextFromWindow@PrivateBrowsingUtils.jsm:49:5 < privateTab.getPrivacyContext@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/Charles/AppData/Roaming/Mozilla/Firefox/Profiles/Charles/extensions/privateTab@bootstrap.js:3994:10 < privateTab.getTabPrivacyContext@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/Charles/AppData/Roaming/Mozilla/Firefox/Profiles/Charles/extensions/privateTab@bootstrap.js:4030:10 < privateTab.isPrivateTab@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/Charles/AppData/Roaming/Mozilla/Firefox/Profiles/Charles/extensions/privateTab@bootstrap.js:4033:24 < privateTab.setTabState@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/Charles/AppData/Roaming/Mozilla/Firefox/Profiles/Charles/extensions/privateTab@bootstrap.js:3418:16 < privateTab.initWindow/<@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/Charles/AppData/Roaming/Mozilla/Firefox/Profiles/Charles/extensions/privateTab@bootstrap.js:436:4 < privateTab.initWindow@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/Charles/AppData/Roaming/Mozilla/Firefox/Profiles/Charles/extensions/privateTab@bootstrap.js:435:3 < privateTab.init@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/Charles/AppData/Roaming/Mozilla/Firefox/Profiles/Charles/extensions/privateTab@bootstrap.js:50:4 < startup@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/Charles/AppData/Roaming/Mozilla/Firefox/Profiles/Charles/extensions/privateTab@bootstrap.js:26:2 < this.XPIProvider.callBootstrapMethod@XPIProvider.jsm:4658:9 < this.XPIProvider.updateAddonDisabledState@XPIProvider.jsm:4785:13 < AddonWrapper.prototype.userDisabled@XPIProvider.jsm:7072:9 < set_userDisabled@extensions.xml:1072:11 < oncommand@about:addons:1:1
sylveon commented 8 years ago

Problem fixed. I just had to restart