Private Tab share same cookies as a normal tab

Infocatcher / Private_Tab

Adds private tabs, restartless extension for Firefox (20.0+) and SeaMonkey (2.17+)

https://addons.mozilla.org/addon/private-tab/

Other

86 stars 20 forks source link

Private Tab share same cookies as a normal tab #206

Closed sylveon closed 8 years ago

sylveon commented 8 years ago

Title says it alls. On latest Firefox Nightly with Private Tabs v 0.1.9.1pre and e10s enabled.

Video

Other little notes I gathered when using the addon:

The private tab marker (Little white mask on violet background near the X) is still visible when I switch to the normal tab.
I can see the new private tab button in a private browsing session.
When I came back to the window I was for filling the issue, I had to relogin.
The tooltip I see when overing the Windows Explorer function isn't localised:

Infocatcher commented 8 years ago

Tab wasn't actually private, that was fixed, see: #202. Bug about indication should be already fixed too.

About localization. French locale isn't complete unfortunately, see https://github.com/Infocatcher/Private_Tab/blob/master/locale/fr/pt.properties (permanent link to latest version) https://github.com/Infocatcher/Private_Tab/blob/e4442e051e8e912c60706d8d0375adecf54e1901/locale/fr/pt.properties (current version)

Test version: private_tab-0.1.9.1pre3-fx-sm.xpi (source code).

(Anyway, looks like multi-process things was updated in latest Nightly and at least inheritance mechanism is broken again)

sylveon commented 8 years ago

0.1.9.1pre3 works. (after a restart)
Firefox Nightly breaks a lot of things.
One day, Stylish stopped working (noooooooo). Two weeks later: magic, it restarted working, without intervention from the maker...
I think we should wait 'til developper edition gets updated and update the addon for it, because Firefox Nightly's APIs can change one day, and revert back the other day. It's not enough stable.

sylveon commented 8 years ago

With 0.1.9.1pre3, the private tab is really private, but I still get the indicator visible until I open a new normal tab.
I don't know why, but the "(Private Browsing)" in the title transferred into all the tabs from the same window and later disappeared. Unable to reproduce after that.

Infocatcher commented 8 years ago

Now should be fixed in Firefox 45-46. And for 47+: #208. https://addons.mozilla.org/addon/private-tab/versions/0.1.9.1

sylveon commented 8 years ago

Fixed