Infocatcher / Private_Tab

Adds private tabs, restartless extension for Firefox (20.0+) and SeaMonkey (2.17+)
https://addons.mozilla.org/addon/private-tab/
Other
86 stars 20 forks source link

Fix 'private:' protocol in Firefox 37-43 and Pale Moon 27+ #248

Closed JustOff closed 7 years ago

JustOff commented 7 years ago

Resolves #247.

Infocatcher commented 7 years ago

Thanks a lot! There is another possible failure: newChannel(uri) -> newChannel2(uri, null) https://github.com/Infocatcher/Private_Tab/blob/0.2.1.2/protocol.jsm#L73 https://github.com/Infocatcher/Private_Tab/blob/0.2.1.2/protocol.jsm#L88 So, I applied a bit different patch: 5df97c5063d758d1c817fab11ed87d1399281859 Anyway, I appreciate your contribution.

JustOff commented 7 years ago

Thank you for fixing the problem!

PS: Would you mind add Pale Moon to install.rdf as target application explicitly? And considering the future end of support of legacy addons in Firefox it would be also nice to host Private Tab at https://addons.palemoon.org (I can assist you in this if needed).