search

Ingenico-ePayments / connect-extension-magento2

Ingenico Connect based Shopping Cart Extension for Magento 2.x
https://epayments.developer-ingenico.com/documentation/ecommerce-extensions/magento-2/
MIT License
4 stars 4 forks source link

Missing creditmemo ends with 500 error #10

Closed Jitheesh closed 4 years ago

Jitheesh commented 4 years ago

https://github.com/Ingenico-ePayments/connect-extension-magento2/blob/e0c2e89951220596712c499774cb5bb55d00ad82/Model/Ingenico/Status/Resolver.php#L206 This line could leads to 500 error and it can be resolved by passing payment transaction Id

https://github.com/Ingenico-ePayments/connect-extension-magento2/blob/e0c2e89951220596712c499774cb5bb55d00ad82/Model/Order/Creditmemo/Service.php#L53 ` public function getCreditmemo(OrderPaymentInterface $payment, $transactionId = null) { if ($payment->getCreditmemo() !== null) { return $payment->getCreditmemo(); }

    if ($transactionId !== null) {
        return $this->getCreditMemoByTxnId($transactionId);
    }

    throw new NotFoundException(
        __('No creditmemo for found.')
    );
}`

Above code will throw exception and because of this creditmemo view will end with 500

Ingenico-Shoppingcarts-zz commented 4 years ago

We are currently changing the setup of the refunds in Magento 2. With the upcoming new release we will verify if this is covered.

kanduvisla commented 4 years ago

Hi @Jitheesh ,

A lot of changes have been done in the refund flow in version 2.2.0 of the module. Could you please check with the latest version of the module if this issue still exists on your side?

kanduvisla commented 4 years ago

I'm closing this issue since there has been no activity for the last 3 months.