Closed fBedecarrats closed 1 year ago
HI @fBedecarrats, thank's for the PR. As it is specific to making the R
extension in VSCode
work, I'd be more enclined to put your command in the VSCode
Dockerfile, in the if
condition just before the installation of the extension : https://github.com/InseeFrLab/images-datascience/blob/main/vscode/Dockerfile#L25. Could you modify your PR ?
OK @avouacr , I modified the PR, removing the included lines in r-python-julia dockerfile and adding them instead in the VSCode Dockerfile:
if command -v R; then \
code-server --install-extension reditorsupport.r && \
R -e "install.packages('languageserver')"; \
Note that I DIDN'T TEST THIS MODIFICATION. I don't know how to test this without completely messing up with the workfkow in place, so I didn't.
Thank's @fBedecarrats. No worries, I just tested it locally and it works. It will be available in our next batch of images, on next Monday.
The VSCode documentation for R Support indicates that the following steps are required:
Step 2 was missing which throws the following warning when the user starts to use R:
I just added one line to install the corresponding package.
Disclaimer: I did not test this line on this specific Dockerfile as it would imply to re-write several of the Github action yamls. However I use it on a Dockerimage that is a child of this one and it works fine.