InseeFrLab / images-datascience

Collection of Docker images to build the data science catalog of the Onyxia project
MIT License
24 stars 22 forks source link

Make use of PACKAGE_MANAGER_URL env variable #128

Closed phlg closed 1 year ago

phlg commented 1 year ago

Linked to a couple of PRs on the helm charts :

This PR changes a couple changes a couple of things related to repository configuration :

⚠️ There are a fair number of points I'm not sure about though, please take them into account when reviewing :

alexisdondon commented 1 year ago

For a first step seems good to me we will see later if we should split certificates and repos for the moment let just move the code as it is.

For renv, the code seems to do something only if one variable at least is injected by onyxia that what i would have do too.

For the shebang, let's align to avoid some problems, https://www.baeldung.com/linux/bash-shebang-lines it seems that the existing shebang is more portable.

phlg commented 1 year ago

Thanks for the review, I fixed the shebang and marked the PR to be ready.

fcomte commented 1 year ago

I think we should set repo before executing user scripts.

phlg commented 1 year ago

I think we should set repo before executing user scripts.

(Hopefully) fixed with 44df6f9, thank you very much !