InseeFrLab / images-datascience

Collection of Docker images to build the data science catalog of the Onyxia project
MIT License
24 stars 22 forks source link

VSCode extension now is called with `reditorsupport.r`, not `njpwerner.reditorsupport.r` #97

Closed fBedecarrats closed 1 year ago

fBedecarrats commented 1 year ago

The VSCode extension for R is not present in the VSCode services available on SSP Cloud. I think that this is due to the command used to install it. The following does not work:

code-server --install-extension njpwerner.reditorsupport.r

The following works:

code-server --install-extension reditorsupport.r
avouacr commented 1 year ago

Thank's @fBedecarrats, it's fixed in 6e47e15e8731dc96f5254a7a3e5aac6180582f33

fBedecarrats commented 1 year ago

Sorry @avouacr but the catalogue image for Vscode-r-python-julia is launched without the R extension, even when I set Service/PullPolicy/Always. Is there something to do to ensure that the fix gets into the SSPCloud catalogue image? Thanks!

avouacr commented 1 year ago

HI @fBedecarrats, indeed, I didn't put the new image in prod, it should be good now. Can you test and confirm ?

fBedecarrats commented 1 year ago

Salut @avouacr! The extension is now available, thanks! Some required packages are still missing for the minimal R to work out of the box. I created a PR to add it (#101).