InseeFrLab / onyxia

🔬 Data science environment for k8s
https://onyxia.sh
MIT License
505 stars 80 forks source link

highlightedCharts is mandatory, but it doesn't have to be #864

Open Yuwei0021 opened 1 month ago

Yuwei0021 commented 1 month ago

In the configuration of a catalog, if we don't include 'highlightedCharts', for example like this :

catalogs: [  
      {  
        "id": "ide",  
        "name": "Data fabrique",   
        "location": "REPOSITORY_HELM",  
        "status": "PROD",  
        "type": "helm",  
        "multipleServicesMode": "maxNumber",  
        "maxNumberOfVersions": 5,  
      }  
]  

When we land on the catalog page via the 'Catalogue de services' button, nothing is displayed.

garronej commented 1 month ago

Ok thank you for reporting!
I'll fix that

garronej commented 1 month ago

Hey @Yuwei0021, unfortunately, i'm unable to reproduce.

I'll let @fcomte or @olevitt tell me if this is an actual issue.

olevitt commented 1 month ago

Hi !

I managed to reproduce on first try in a brand New instance, with a single catalog, with no (Key not present) highlightedChart. On both V8 and v9. Adding `highlightedCharts: [...]" solved the issue

garronej commented 1 month ago

Looking at the code I can't figure out what's going on and surely if highlightedCharts I set it to an empty array...
Can you have a look at what the API sends back? Maybe it sends an empty string as value of highlightedCharts or something.

olevitt commented 1 month ago

Looking at the code I can't figure out what's going on and surely if highlightedCharts I set it to an empty array... Can you have a look at what the API sends back? Maybe it sends an empty string as value of highlightedCharts or something.

I will set you up an env with the bug tomorrow

olevitt commented 1 month ago

Looking at the code I can't figure out what's going on and surely if highlightedCharts I set it to an empty array... Can you have a look at what the API sends back? Maybe it sends an empty string as value of highlightedCharts or something.

I will set you up an env with the bug tomorrow

Could not reproduce today.
I swear I had the issue yesterday with the following configuration on both the latest v8 and latest v9 :

  ingress:
    enabled: true
    hosts:
      - host: <myurl>
    tls:
      - hosts:
          - <myurl>

  api:
    catalogs:
      [
        {
          id: "ide",
          name: "Interactive services",
          location: "https://inseefrlab.github.io/helm-charts-interactive-services",
          status: "PROD",
          type: "helm"
        }
      ]