Review Lowercase / uppercase checks and case naming convention in framework

Insight-Services-APAC / APAC-Capability-DAI-DbtFabricSparkNb

MIT License

8 stars 2 forks source link

Closed KRodriguez-Insight closed 1 month ago

KRodriguez-Insight commented 1 month ago

Consider having namespace comparison in lower case. similar to issue #94
Additionally some of the naming convention related to notebook are inconsistent (to consider lower case naming convention and query generation in note book.

KRodriguez-Insight commented 1 month ago

The intent of this ticket was to standardize the SQL artifact naming convention on the following

Schema and table name printed in log ( The logs are generated by the DBT modules and not from FabricSparknb modules).
Testing the changes to convert the sql generated in notebook to lower case.

Require some more time to test the changes , would like to move this to next release

KRodriguez-Insight commented 1 month ago

Changes include conversion if SQL syntax in model notebook to lower case

insightgrantkrieger commented 1 month ago

Closed user must write the correct case in the model