search

InsightSoftwareConsortium / ITK

Insight Toolkit (ITK) -- Official Repository. ITK builds on a proven, spatially-oriented architecture for processing, segmentation, and registration of scientific images in two, three, or more dimensions.
https://itk.org
Apache License 2.0
1.43k stars 668 forks source link

DO_NOT_MERGE: Wip apply clang format #4991

Open hjmjohnson opened 4 days ago

hjmjohnson commented 4 days ago

ONLY 1/2 Done refactoring.

Looking for quick comments/suggestions.

PR Checklist

N-Dekker commented 4 days ago 
STYLE: One declaration per line for readability
STYLE: One declaration per line for readability
STYLE: One declaration per line for readability
STYLE: One declaration per line for readability

Please use more specific commit message headers. Ideally a different message header for each commit. Or, if they all do exactly the same thing, please squash them together.

N-Dekker commented 3 days ago

Please make a separate pull request for each type of refactoring. Especially when they involve hundreds or more lines of code.

"One declaration per line" is a different type of refactoring than moving variable declarations closer to their first use.

hjmjohnson commented 2 days ago

@N-Dekker Thank you for your comments.

This work is getting too much out of hand to do with this approach. I'm going to step back and work on a smaller set of incremental updates.

I appreciate your feedback very much. It will guide my second attempt at this.

FYI:
I plan to submit a 1). clang-tidy readability-isolate-declaration update that has very little value on it's own, but it greatly facilitates the next steps. 2) Make a pass that does many very trivial changes (almost no benefit on it's own). i.e. like 18d683ec792bfa7b7a950f781cf9836a5ef64a4d

3) Make a pass through modules making more aggressive changes. 4) -- I may ask you to run some of your scripts like c77f9f8da0d12d791159d0f23cfd7a6097c99f37