ENH: Import libLBFGS from upstream

InsightSoftwareConsortium / ITK

Insight Toolkit (ITK) -- Official Repository. ITK builds on a proven, spatially-oriented architecture for processing, segmentation, and registration of scientific images in two, three, or more dimensions.

https://itk.org

Apache License 2.0

1.47k stars 686 forks source link

ENH: Import libLBFGS from upstream #5175

Closed bradking closed 3 weeks ago

bradking commented 3 weeks ago

It was originally imported by 7fba333f6688a368f33d1c085f1c5545786faad2, but just by copying source files.

Import the same version using our modern third-party import infrastructure.

Closes #3135.

blowekamp commented 3 weeks ago

There were a few commit since the initial import: 0402e50150 COMP: remove try-compile for SSE2 detection 0ba93de147 BUG: Use explicit libm linking only on UNIX. 8afc60c202 Explicit libm linking for NrrdIO and libLBFGS. 9f187bde39 BUG: stdint.h missing on Visual Studio 9

Reviewing them I don't think any made substantiative changes that need to be included.

PR LGTM! Thanks!

seanm commented 3 weeks ago

0402e50 COMP: remove try-compile for SSE2 detection

That looks valuable for Universal Binaries on macOS. Anyway, will be easy to update later thanks to @bradking's work here.