InsightSoftwareConsortium / ITK

Insight Toolkit (ITK) -- Official Repository. ITK builds on a proven, spatially-oriented architecture for processing, segmentation, and registration of scientific images in two, three, or more dimensions.
https://itk.org
Apache License 2.0
1.47k stars 686 forks source link

Move empty member function definitions from "itk*.hxx" to "itk*.h" #5198

Closed N-Dekker closed 2 weeks ago

N-Dekker commented 2 weeks ago

Moved the member function definitions of member functions that have an empty parameter list and an empty member function definition from their "itk.hxx" file to the corresponding "itk.h" file, and into their class definition.

Defaulted the default-constructor of PyImageFilter.

Found by regular expression ::.+\(\)\r\n{} in "itk*.hxx" files.

Suggested by Denis Shamonin (@dpshamonin).

N-Dekker commented 2 weeks ago

The test failure of itkConvolutionImageFilterStreamingValidTest at https://open.cdash.org/viewTest.php?onlyfailed&buildid=10177192 looks unrelated to me. It says:

Exception detected while reading D:/a/1/s-build/ExternalData/Modules/Filtering/Convolution/test/Baseline/itkConvolutionImageFilterStreamingTestOutput.mha : ITK ERROR: MetaImageIO(0000022064FE9E70): File cannot be read: D:/a/1/s-build/Testing/Temporary/ITKConvolution/itkConvolutionImageFilterStreamingTestOutput.mha for reading.
Reason: No such file or directory
N-Dekker commented 2 weeks ago

/azp run ITK.Windows