Closed tbirdso closed 1 year ago
Also observed in build-test-cxx (ubuntu)
in ITKSplitComponents:
https://github.com/tbirdso/ITKSplitComponents/actions/runs/5645564369/job/15291583317
https://open.cdash.org/viewBuildError.php?buildid=8860614
test/itkSplitComponentsImageFilterTest.cxx:40:22: error: 'is_same_v' is not a member of 'std'; did you mean 'is_same'?
@thewtex I propose we investigate a resolution for this issue further as part of ITK v5.4.0 preparation.
@tbirdso this is likely fixed with the v5.4rc01 builds where the C++ standard is 17 by default via ITK.
ITKElastix C++17 is now building with https://github.com/InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction/tree/v5.4.0. Thanks for getting v5.4rc1 packages out @thewtex 👍
Expected behavior
ITK requires building with C++17 or later.
https://github.com/InsightSoftwareConsortium/ITK/blob/3454d857dc46e4333ad1178be8c186547fba87ef/CMake/ITKInitializeCXXStandard.cmake#L2-L4
Observed behavior
ITKElastix build observed to fail in
build-macos-py
due to building with C++14.https://github.com/InsightSoftwareConsortium/ITKElastix/pull/234#issuecomment-1644164635
build-macos-py
pipeline should be updated to build with-std=c++17
.