Closed BrentMifsud closed 2 years ago
We're looking into this. Can I ask if the redirected requests are failing or passing?
the redirects are going through.
But I did notice that while network logging is enabled, there seems to be a slight memory leak (about ~2 megabytes per hour) I did dive into instruments to take a look, I did see some references to IBGURLSessionDemux
in there. Might be related to this.
Our app is an iPad kiosk that needs to run for long periods of time. And this was causing the app to kill itself after a week or so of runtime.
Can you export the instruments trace and send it please? Or if not possible a screenshot of the leak could also be useful.
Can you export the instruments trace and send it please? Or if not possible a screenshot of the leak could also be useful.
Yea I can send one over.
Its not a huge leak. But over the course of a week or two it was causing our iPad app to kill itself from memory usage.
We did some tests on our end, removing the Network logging. No leak with Network logging disabled.
This was all on the latest version of instabug.
Here are some screenshots as well:
@hassaanelgarem sent you a copy of the trace to the email you have on your GitHub profile.
@BrentMifsud Thank you! We'll take a look and get back to you soon.
@BrentMifsud Thank you! We'll take a look and get back to you soon.
Great! thanks for looking into this.
Hi @BrentMifsud, Would you please set this block -[IBGNetworkLogger setTaskWillPerformHTTPRedirectionBlock:]
if your app attempting to perform a redirection to a different URL and you have network logging enabled.
Regrading the memory leaks, We're still looking into it but could you please reproduce the leaks after passing your completionHandler to our API and send us the memory graph of the leaks.
@husseinkishk By adding that completion handler you mentioned above, the memory leak, and console messages are now gone.
I did export a memory graph before adding the completion handler that still has the leaks present. Do you have an email I can send it to? Id prefer not to dump my memory graph publicly on GitHub.
@BrentMifsud I've the one you shared before to my colleague. Thank you.
This issue has been automatically marked as stale due to inactivity. It will be closed if no further activity occurs. Thank you for your contributions.
Bumping this to keep it open.
This issue has been automatically marked as stale due to inactivity. It will be closed if no further activity occurs. Thank you for your contributions.
@BrentMifsud I'm glad to inform you that this issue should be fixed on the latest version 10.11.4. I'd really like to thank you for opening this ticket which helped in increasing our SDK quality 🎉 I am closing this issue but feel free to reopen it if the issue persists 🙏
Steps to Reproduce the Problem
Enabled instabug network logging
Expected Behavior
Should not be seeing console log messages
Actual Behavior
Instabug integration code
SDK Version
10.11.0
iOS Version
15.1
Device Model
iPad
[Optional] Project That Reproduces the Issue