IntelLabs / GKL

Accelerated kernel library for genomics
MIT License
105 stars 41 forks source link

Change from using the java plugin to the java-library plugin #197

Closed lbergelson closed 1 year ago

lbergelson commented 1 year ago

I noticed when upgrading gkl 8.8.0 -> 8.11.0 in picard that there were build errors when doing so. There were changes in gradle which make it so that it doesn't treat implementation dependencies of other projects as compile time dependencies. This was causing issues because we didn't explicitly depend on gatk-native-library but it's part of the exposed API of the gkl which we call.

Specifying these as API dependencies should fix the problem by letting gradle know that they are needed at compile time.

My machine isn't set up to run the native build so I haven't tested this properly but I think it should work.

(This is easy to work around by just adding explicit dependencies, but it would be better if it wasn't necessary.)