IntelligentRoboticsLab / DNT2013

Code base of the Dutch Nao Team for the Standard Platform League of the Robocup.
7 stars 1 forks source link

Remove hardcoded values from the XABSL behavior #39

Open pkok opened 11 years ago

pkok commented 11 years ago

During yesterday's meeting, @aukejw told us there are some values hardcoded in the behaviors (discovered doing #17, #18, #23, #24), such as the goalie's square's dimensions. This ugly hardcodedness should be replaced with nice variables.

aukejw commented 11 years ago

As I'm still not entirely sure what some hardcoded values mean, I'm a little bit afraid to just change them. However, these:

(robot_pose.x < -3000 || robot_pose.x > -2400 || robot_pose.y < -1100 || robot_pose.y > 1100)) {

obviously indicate the goalies box. Everything is expressed in mm, where (0,0) is the center of the field, and negative values stand for backwards and to the left for x and y respectively, as seen from our point of view.