search

Interlisp / medley

The main repo for the Medley Interlisp project. Wiki, Issues are here. Other repositories include maiko (the VM implementation) and Interlisp.github.io (web site sources)
https://Interlisp.org
MIT License
378 stars 19 forks source link

The BIGNUM declaration is not in EXPORTS.ALL #859

Closed rmkaplan closed 2 years ago

rmkaplan commented 2 years ago

It is defined in LLBIGNUM, used at least by TEDIT. Should be exported

nbriggs commented 2 years ago

Shouldn't that code be doing (TYPEP NEWLEN 'BIGNUM) or (TYPENAMEP NEWLEN 'BIGNUM) ?

masinter commented 2 years ago

The (type? BIGNUM call in TEdit) was a hack I should have not introduced. Trying to HCFILES (TEdit Hardcopy) of the envos repo hit a (at the time fatal) RAID call because it was trying to PUTBASEFIXP of a BIGNUM in the middle of an UNINTERRUPTABLE section of code.

rmkaplan commented 2 years ago

I’l try one of those.

On Jul 22, 2022, at 9:14 AM, Nick Briggs @.***> wrote:

Shouldn't that code be doing (TYPEP NEWLEN 'BIGNUM) or (TYPENAMEP NEWLEN 'BIGNUM) ?

— Reply to this email directly, view it on GitHub https://github.com/Interlisp/medley/issues/859#issuecomment-1192732416, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQSTUJONHV3JSI3DQYSAIC3VVLCFPANCNFSM54L6ZNPA. You are receiving this because you authored the thread.

masinter commented 2 years ago

just turn it into a > 0 < max piece-length test.

rmkaplan commented 2 years ago

Does max-piece-length already exist?

On Jul 22, 2022, at 11:42 AM, Larry Masinter @.***> wrote:

just turn it into a > 0 < max piece-length test.

— Reply to this email directly, view it on GitHub https://github.com/Interlisp/medley/issues/859#issuecomment-1192843765, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQSTUJNH6SUTFKRMSEDRXUDVVLTRNANCNFSM54L6ZNPA. You are receiving this because you authored the thread.

nbriggs commented 2 years ago

I would check if (the error case)NEWLEN is < 0 or > MAX.FIXP since Larry pointed out it was

trying to PUTBASEFIXP of a BIGNUM

rmkaplan commented 2 years ago

OK

On Jul 22, 2022, at 11:53 AM, Nick Briggs @.***> wrote:

I would check if (the error case)NEWLEN is < 0 or > MAX.FIXP since Larry pointed out it was

trying to PUTBASEFIXP of a BIGNUM

— Reply to this email directly, view it on GitHub https://github.com/Interlisp/medley/issues/859#issuecomment-1192850685, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQSTUJPJUMUZSEPK6OA7ZCLVVLUZHANCNFSM54L6ZNPA. You are receiving this because you authored the thread.