Fix connection issues with local master if only connected usb tethering used.

Intermodalics / tango_ros

ROS related software for Tango

Apache License 2.0

67 stars 22 forks source link

Fix connection issues with local master if only connected usb tethering used. #359

Closed malteim closed 7 years ago

malteim commented 7 years ago

Fixes this this issues:

App was crashing if local master was enabled and the phone was offline.
App was crashing because of connection issues with parameter node (java.lang.RuntimeException: java.net.ConnectException: failed to connect to /192.168.42.129 (port 11311): connect failed: ENETUNREACH (Network is unreachable)).

PerrineAguiar commented 7 years ago

test this please

PerrineAguiar commented 7 years ago

@malteim Thanks again, I fixed the remaining issues.

meyerj commented 7 years ago

@malteim Small remark: If I enable local master and there are no active network connections (no Wifi or USB tethering enabled) the app shows the last configured external ROS_MASTER_URI. Not really a problem as there is no way to communicate from the outside. But either the app should show http://localhost:11311 as the master URI or simply exit with an error message.

PerrineAguiar commented 7 years ago

@meyerj The app does show an error message. But it is true that the user can miss it since it is displayed as a toast message.