Fix/better default for occupancy grid threshold

Intermodalics / tango_ros

ROS related software for Tango

Apache License 2.0

67 stars 22 forks source link

Closed PerrineAguiar closed 7 years ago

PerrineAguiar commented 7 years ago

This PR changes the default value of the occupancy grid threshold to 180. It was set to 128, which does not give good result.

Fixes #365.

mcopejans commented 7 years ago

LGTM Is a 'good' value for this threshold device dependent? Is this a good value for the tablet, Lenovo and Asus devices?

PerrineAguiar commented 7 years ago

This was tested only on Lenovo, so I am not sure if this is device dependent. I am merging this PR for now since Lenovo is the most used currently.