search

Intermodalics / tango_ros

ROS related software for Tango
Apache License 2.0
67 stars 22 forks source link

callTangoConnectService never returns #369

Closed adamantivm closed 7 years ago

adamantivm commented 7 years ago

After long debugging today I realized that callTangoConnectService is currently working in a way such that, when the connection succeed, the call never returns. This is very misleading behavior, especially given that the call has a return code to indicate if the call succeeded or not. This also makes it much more complicated to notify the application when the connection has been successful.

The proper behavior would be to return true on success and let the application thread continue.

adamantivm commented 7 years ago

This was a user error (me). The call is actually returning properly.