Add api level parameter to avoid connecting to fisheye on Asus

Intermodalics / tango_ros

ROS related software for Tango

Apache License 2.0

67 stars 22 forks source link

Add api level parameter to avoid connecting to fisheye on Asus #371

Closed PerrineAguiar closed 7 years ago

PerrineAguiar commented 7 years ago

TangoService_connectOnFrameAvailable is not supported on Asus phones for the fisheye camera. This was causing the app to fail connecting to Tango on Asus phones.

To fix this, this PR exposes the API level of the device on a ROS parameter and decide to connect to 'onFrameAvailable' or not (Asus phone has API level 24 while Lenovo has 23).

Fixes #314.

PerrineAguiar commented 7 years ago

@mcopejans Thanks, I addressed your comment.