Intermodalics / tango_ros

ROS related software for Tango
Apache License 2.0
67 stars 22 forks source link

Release tango_ros_messages as binary packages into ROS indigo and kinetic #381

Closed meyerj closed 6 years ago

meyerj commented 6 years ago

This is required to release tango_ros_messages version 1.3.1 using bloom.

All other packages cannot easily be submitted for binary releases to the ROS build farm because the third-party dependencies, including the Tango Client API, cannot be released without permission and are not available for all ROS target platforms. But the message package is already useful to communicate with the TangoRosStreamer app running on an Android device.

meyerj commented 6 years ago

I created a bloom release repository at https://github.com/Intermodalics/tango_ros-release with a copy of version 1.3.1 from this branch and initial releases into ROS indigo and kinetic. All went well and we could submit a PR to https://github.com/ros/rosdistro to trigger the build farm?

PerrineAguiar commented 6 years ago

@meyerj Looks good but won't this conflict with the rosjava version of the tango_ros_messages package (see here), which is at 2.0.0?

meyerj commented 6 years ago

Probably yes. In this case we have to keep the version number 2.0.0, which is not a problem as long as all other packages are ignored. But normally bloom expects that all packages within the same repository have the same version, and that version should correspond to the git tag name somehow.

I will revert the first commit and only keep the second and do another release for version 2.0.0.

meyerj commented 6 years ago

Done: